Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelmService Remove unused imports #2923

Closed
1 task
manusa opened this issue Apr 17, 2024 · 3 comments
Closed
1 task

HelmService Remove unused imports #2923

manusa opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest

Comments

@manusa
Copy link
Member

manusa commented Apr 17, 2024

Description

The class HelmService has unused imports.

The following lines:

  • should be removed

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Apr 17, 2024
@Suhas-Koheda
Copy link

Please assign this to me

@manusa manusa added the Hacktoberfest Issues accountable for the Hacktoberfest label Sep 25, 2024
@manoj-r
Copy link

manoj-r commented Oct 3, 2024

I'd like to fix this. Can you please assign this to me?

@manoj-r
Copy link

manoj-r commented Oct 4, 2024

@rohanKanojia Looks like this was already fixed by @manusa. This issue can be closed. https://github.com/eclipse-jkube/jkube/blob/master/jkube-kit/helm/src/main/java/org/eclipse/jkube/kit/resource/helm/HelmService.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants