Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssemblyFileSetUtilsExcludesTest.setUp The declared Exception exception is never thrown #2591

Open
1 task
manusa opened this issue Jan 31, 2024 · 11 comments
Open
1 task

AssemblyFileSetUtilsExcludesTest.setUp The declared Exception exception is never thrown #2591

manusa opened this issue Jan 31, 2024 · 11 comments
Assignees
@shree-crypto
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest

Comments

@manusa
Copy link
Member

manusa commented Jan 31, 2024 •
edited
Loading

Description

The method AssemblyFileSetUtilsExcludesTest.setUp declares an Exception that is never thrown.

The following line

jkube/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/archive/AssemblyFileSetUtilsExcludesTest.java

Line 33 in 5da6068

public void setUp() throws Exception {

  • should be changed to:
  public void setUp() {

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)
@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Jan 31, 2024
@ShantKhatri
Copy link
Contributor

Can I work on this? Could you please assign this to me.

@rohanKanojia
Copy link
Member

rohanKanojia commented Jan 31, 2024 •
edited
Loading

@ShantKhatri : I'm not 100% sure about I think you've contributed previously to the project. Am I right? first-timers-only tagged issues are created for people who are contributing to the project for the first time.

@rohanKanojia
Copy link
Member

@ShantKhatri : I think you were working on #2316 . You analyzed tests that might require refactoring to reduce dependency on mockito.

I think we can create sub-tasks from that spread sheet as isolated issues. I've created #2597 #2598 . Would you be interested in working on it?

@ShantKhatri
Copy link
Contributor

@ShantKhatri : I think you were working on #2316 . You analyzed tests that might require refactoring to reduce dependency on mockito.

I think we can create sub-tasks from that spread sheet as isolated issues. I've created #2597 #2598 . Would you be interested in working on it?

Sure, I'll work on these issues.

@Harshitchopde
Copy link

Hii i am new to open source and want to contribute to this project and i have good knowledge of java and Android in java .
but i dont know to run the project locally i have try so many thing but it fails . so can anyone please help me in set-up and run it locally

@Harshitchopde
Copy link

Error when running command
$ mvn clean install
Screenshot 2024-02-06 183317
Screenshot 2024-02-06 183329

@manusa
Copy link
Member Author

manusa commented Feb 7, 2024

You won't be able to run some tests on Windows.
To build the project you'll need to provide the -DskipTests maven flag.
For this particular issue, we can rely on the build automation platform to ensure that you didn't break anything.
Shall I assign this to you @Harshitchopde ?

@Harshitchopde
Copy link

You won't be able to run some tests on Windows. To build the project you'll need to provide the -DskipTests maven flag. For this particular issue, we can rely on the build automation platform to ensure that you didn't break anything. Shall I assign this to you @Harshitchopde ?

sure

@Juhi-Lakdawala
Copy link

Hey I want to work on this issue can you assign this to me

@manusa manusa added the Hacktoberfest Issues accountable for the Hacktoberfest label Sep 25, 2024
@shree-crypto
Copy link

if this is still open would love to work on this as my first contri @manusa

@rohanKanojia rohanKanojia mentioned this issue Oct 13, 2024
Open
This was referenced Oct 14, 2024
Open
Open
@invictus04
Copy link
Contributor

Can i work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shree-crypto shree-crypto

Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@manusa @rohanKanojia @shree-crypto @ShantKhatri @invictus04 @Harshitchopde @Juhi-Lakdawala