Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebean-test: Modify postgis platform to support both net.postgis and og.postgis #3449

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

rbygrave
Copy link
Member

Use Class.forName() to test existence of net.postgis.jdbc.DriverWrapperLW and if available use that driver rather than the older org.postgis.DriverWrapperLW one.

Also support explicitly specifying the driver to use via test property - ebean.test.postgis.driver

…rg.postgis

Use Class.forName() to test existence of net.postgis.jdbc.DriverWrapperLW and if available use that driver rather than the older org.postgis.DriverWrapperLW one.

Also support explicitly specifying the driver to use via test property - ebean.test.postgis.driver
@rbygrave rbygrave self-assigned this Jul 30, 2024
@rbygrave
Copy link
Member Author

Hi @Ryszard-Trojnacki , can you check if you are happy with this.

@Ryszard-Trojnacki
Copy link
Contributor

I have checked this and:

  1. Works as expected. I added log to this and driver was selected correctly.
  2. You should probably remove NetPostgisSetup now because it is not needed and remove it registration from PlatformAutoConfig: KNOWN_PLATFORMS.put("netpostgis", new NetPostgisSetup());.

@rbygrave
Copy link
Member Author

Great thanks.

You should probably remove NetPostgisSetup now ...

Ah yes, good point. I'll do that.

Thanks !!

@rbygrave rbygrave added this to the 14.5.1 milestone Aug 27, 2024
@rbygrave rbygrave merged commit 86c7de2 into master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants