Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Optimized the DependantTable handling #3150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Optimized the DependantTable handling #3150

wants to merge 1 commit into from

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented Aug 9, 2023

Instead of copying dependant tables around, here I've refactored the dependant table handling

rPraml
rPraml commented Aug 9, 2023
View reviewed changes
ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java
return true;
} else {
if (!this.cacheBeans.isEmpty()) {
updateQueryPlanKey();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKME: Do we have a test for this code path...

@rPraml
Copy link
Contributor Author

rPraml commented Aug 9, 2023

This is part of #2937 and might be merged separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rPraml