IMPROVED: checkUniqueness supports queryCache and skipClean #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. The javadoc for the public API needs filling in for the new parameters and this is added in a breaking API way. |
|
Hello @rob-bygrave FYI: I also changed the default of "skipClean" to true here, as it makes no sense to check clean properties against unique-violations (the property comes from the database and will not be updated anyway when saving that bean) |
rPraml
changed the title
rPraml
added a commit
to FOCONIS/ebean
that referenced
this pull request
Aug 10, 2023
rPraml
force-pushed
the
checkunique-improvement
branch
from
77696a8
to
bc75aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rob, with #1303 I implemented the checkUniqueness method, that we use in validation to verify that a new or modified bean does not violate unique constraints of the database.
This is neccessary to provide good user feedback in our UI
As already mentioned in #1303, this could be a performance killer, especially if you do a mass import/update of some entities, where unique constraints are involved. To minimize this, I tried to do two improvements
skipCleanif you load a bean from database and do not touch the unique properties, they need not to be validateduseQueryCacheI use anexistsquery instead offindCountas this may be slightly faster. Adittionally I enabe the queryCache on that query. This eliminates subsequent DB hits if the bean gets validated multiple times