Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21470] Apply @Blast545 contribution: Add unsigned specification to literals (#5125) #5149

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[21470] Apply @Blast545 contribution: Add unsigned specification to literals (#5125) #5149

merged 1 commit into from
Aug 19, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Aug 8, 2024 •
edited
Loading

Description

This PR is a mimic of

which is opened by an eProsima Team member in order to run internal CI.
No tests are needed, but just the library build.
This fix may also be needed in the 2.10.x Iron version, so it is marked as a backportable PR.

@Mergifyio backport 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Aug 8, 2024
@JesusPoderoso JesusPoderoso added this to the v2.14.4 milestone Aug 8, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 8, 2024
Mario-DL
Mario-DL approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Aug 8, 2024
@Blast545
Copy link

ping 🙏

@MiguelCompany MiguelCompany merged commit daef938 into 2.14.x Aug 19, 2024
15 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/blast545_unsigned_specification_to_literals branch August 19, 2024 05:46
@MiguelCompany
Copy link
Member

@Blast545 Sorry for the delay. Vacations made this linger a bit

@MiguelCompany
Copy link
Member

@Mergifyio backport 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 19, 2024 •
edited
Loading

backport 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 19, 2024
@JesusPoderoso @mergify
Add unsigned specification to literals (#5125) (#5149)
9437a7d 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)
@mergify mergify bot mentioned this pull request Aug 19, 2024
Merged
10 tasks
MiguelCompany pushed a commit that referenced this pull request Aug 19, 2024
@mergify @JesusPoderoso
Add unsigned specification to literals (#5125) (#5149) (#5161)
44a6089 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)

Co-authored-by: Jesús Poderoso <120394830 [email protected]>
@MiguelCompany
Copy link
Member

@Mergifyio backport master

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 19, 2024 •
edited
Loading

backport master

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 19, 2024
@JesusPoderoso @mergify
Add unsigned specification to literals (#5125) (#5149)
390a5b0 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)
@mergify mergify bot mentioned this pull request Aug 19, 2024
Merged
10 tasks
MiguelCompany pushed a commit that referenced this pull request Aug 20, 2024
@mergify @JesusPoderoso
Add unsigned specification to literals (#5125) (#5149) (#5162)
bbb4c58 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)

Co-authored-by: Jesús Poderoso <120394830 [email protected]>
@Blast545
Copy link

Can I ask for this to also be backported to 2.6.x as well? Since that's the one used for humble and we have the warnings appearing there 🙇

Thanks in advance! @MiguelCompany

@Blast545 Blast545 mentioned this pull request Aug 23, 2024
Merged
@JesusPoderoso
Copy link
Contributor Author

Hi @Blast545,
According to our release support guidelines Fast DDS v2.6.9 was the last patch version receiving backported features and bugfixes. Since then, the v2.6 minor would only receive patches for critical issues and security fixes.
However, we have internally considered including this backport in 2.6.x too.

@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 26, 2024 •
edited
Loading

backport 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@JesusPoderoso @mergify
Add unsigned specification to literals (#5125) (#5149)
b9ca5fc 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)

# Conflicts:
#	include/fastdds/rtps/common/InstanceHandle.h
@mergify mergify bot mentioned this pull request Aug 26, 2024
Merged
10 tasks
JesusPoderoso added a commit that referenced this pull request Aug 26, 2024
@JesusPoderoso
Add unsigned specification to literals (#5125) (#5149)
3ded683 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit daef938)
Signed-off-by: JesusPoderoso <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Aug 26, 2024
@mergify @JesusPoderoso
Add unsigned specification to literals (#5125) (#5149) (#5174)
4c460ef 
(cherry picked from commit daef938)

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Jesús Poderoso <120394830 [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.4
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @Blast545 @MiguelCompany @Mario-DL