Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21424] Add test for support of enumeration literal @value annotation #5109

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 26, 2024

Description

Add a new test for new enumeration in dds-types-test repository.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Add test for support of enumeration literal @value annotation [21424] Add test for support of enumeration literal @value annotation Jul 26, 2024
@richiware richiware added this to the v3.0.1 milestone Jul 26, 2024
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Aug 9, 2024
@Mario-DL Mario-DL modified the milestones: v3.0.1 - frozen, v3.0.2 Sep 5, 2024
@github-actions github-actions bot added ci-pending PR which CI is running labels Sep 9, 2024
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany September 26, 2024 08:49
thirdparty/fastcdr Outdated Show resolved Hide resolved
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed labels Sep 30, 2024
@richiware richiware merged commit ed41ddb into master Oct 1, 2024
14 of 17 checks passed
@richiware richiware deleted the bugfix/21379 branch October 1, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants