[Sources] Allow source_diff to wrap dead sources in quotes #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554
Allows you to wrap sources in quotes, meaning dead sources can be added like so:
and removed (oddly) like so:
Yeah, it's weird, but it's better than not being able to do it.
This isn't required though, you can add/remove regular sources exactly the same as before. This does however mean no sources can start or end with quotes (when added with
source_diff
), which at the moment affects 40 posts:https://e621.net/posts?tags=~source:\"* ~source:*\"
and I'd argue all of them are invalid sources anyways...
Alternatively, the prefix/suffix can be anything, it doesn't need to be quotes.