Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Support gcp secrets #498

Open
gabicavalcante opened this issue Dec 30, 2020 · 5 comments
Open

[RFC] Support gcp secrets #498

gabicavalcante opened this issue Dec 30, 2020 · 5 comments
Labels
Not a Bug Not a Problem, expected behavior RFC
Milestone
4.0.0

Comments

@gabicavalcante
Copy link

Is your feature request related to a problem? Please describe.
I'm running an app in the google cloud and using the google secret manager to store passwords and tokens. Currently we don't have a good solution to manager secrets in multiple environments using secrets manager, we need to everytime change to environment variable when we are running locally. I'd like to integrate dynaconf with gsecrets.

Describe the solution you'd like
I found this project https://github.com/binxio/gcp-get-secret. It is a client to configure environment variable with values from google secret manager. I was thinking about using the similar strategy and build a loader to do this:
The secrets could be specified usinig the following formats:

[default]
SECRET = "gcp:{name}"
SECRET = "gcp:{name}/{version}"
SECRET = "gcp:{project}/{name}"
SECRET = "gcp:{project}/{name}/{version}"
SECRET = "gcp:{projects}/{project}/{secrets}/{name}/versions/{version}"

I'm going to look how the vault integration works, but before starting to code, I would like to know if makes sense to build this loader.
@gabicavalcante gabicavalcante added Not a Bug Not a Problem, expected behavior RFC labels Dec 30, 2020
@rochacbruno rochacbruno added this to the 4.0.0 milestone Mar 2, 2021
@sephiartlist
Copy link

Hi,
If this is not too complicated I'll be happy to try and assist in a PR (but I'll need to have some guidance)

@rochacbruno rochacbruno mentioned this issue Jul 19, 2021
Open
@stale
Copy link

stale bot commented Jun 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2022
@sephiartlist
Copy link

@rochacbruno please update if you think you can support me on working on this PR

@rochacbruno
Copy link
Member

HI @sephiartlist sure! start looking at how loaders are defined

@stale stale bot removed the wontfix label Jun 6, 2022
@sephiartlist
Copy link

should we wait to see the final implementation of issue #586 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Not a Bug Not a Problem, expected behavior RFC
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@rochacbruno @gabicavalcante @sephiartlist