Handle empty compressed responses with content-length > 0 #257

ducaale · 2022-05-14T18:36:52Z

Resolves #253

ducaale · 2022-05-14T18:41:18Z

src/decoder.rs

+ Err(e) if decoder.get_ref().has_errored => Err(e),
+ Err(_) if !decoder.get_ref().has_read_data => Ok(0),


The check has to be done in this order to avoid ignoring InnerReader errors when no data has been read

blyxxyz

Works great!

handle empty gzip responses with content-length > 0

580ae5d

ducaale commented May 14, 2022

View reviewed changes

blyxxyz approved these changes May 14, 2022

View reviewed changes

ducaale merged commit 898dc2e into master May 14, 2022

ducaale deleted the emtpy-gzip-head-response branch May 14, 2022 19:40

ducaale changed the title ~~Handle empty gzip responses with content-length > 0~~ Handle empty compressed responses with content-length > 0 May 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle empty compressed responses with content-length > 0 #257

Handle empty compressed responses with content-length > 0 #257

ducaale commented May 14, 2022

ducaale May 14, 2022

blyxxyz left a comment

		Err(e) if decoder.get_ref().has_errored => Err(e),
		Err(_) if !decoder.get_ref().has_read_data => Ok(0),

Handle empty compressed responses with content-length > 0 #257

Handle empty compressed responses with content-length > 0 #257

Conversation

ducaale commented May 14, 2022

ducaale May 14, 2022

Choose a reason for hiding this comment

blyxxyz left a comment

Choose a reason for hiding this comment