Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.rs should not detect nightly feature #260

Closed
loynoir opened this issue Oct 24, 2023 · 1 comment
Closed

build.rs should not detect nightly feature #260

loynoir opened this issue Oct 24, 2023 · 1 comment

Comments

@loynoir
Copy link

loynoir commented Oct 24, 2023 •
edited
Loading

quote

rust-lang/cargo#12872 (comment)

Personally, I think auto-detecting nightly features is a mistake and instead feature flags should be used to enable them explicitly.

actual

build.rs detect nightly feature.

thiserror/build.rs

Lines 12 to 13 in e9ea67c

const PROBE: &str = r#"
#![feature(error_generic_member_access)]

expected

build.rs should not detect nightly feature.
@loynoir
Copy link
Author

loynoir commented Oct 25, 2023

Close as dtolnay not agree with epage.

dtolnay/anyhow#323 (comment)

@loynoir loynoir closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loynoir