Relativize symlinks where possible #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to relativize symlinks. Fixes dtolnay#1250. - Do not relativize where target or link are relative paths. - Do not relativize where CARGO_TARGET_DIR is set, as this indicates that relativizing might not be helpful. - Do not relativize where source or target contain `..`
dtolnay
force-pushed
the
jbaker/relativise_symlinks
branch
from
1ea4807
to
63f2475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to relativize symlinks. Fixes #1250.
..It feels a bit weird where it is because the module is filesystem-specific, cxx-agnostic, but I justified it to myself on the basis that it's cxx's interface for interacting with the filesystem specifically for the purpose of writing output.