fix: getBodyText() doesn't work as would be expected #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you so much! This is my first real OSS contribution, so I appreciate this a lot. Thanks for being a maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559
The first test corresponds to the first issue mentioned in #1559, which is definitely a bug. This is addressed by the addition of the new if statement at the end of the while loop. The second test corresponds to my preferred behavior of ignoring empty lines when adjusting indentation levels. This was addressed by the modification of the condition to update the minimum indent level. If you do not believe this should be default behavior, at least an option should be provided, since I'm finding it necessary for my use case.
Please let me know if you have any thoughts.