Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer able to build site #153

Closed
Gerrit0 opened this issue Jun 12, 2024 · 4 comments
Closed

No longer able to build site #153

Gerrit0 opened this issue Jun 12, 2024 · 4 comments

Comments

@Gerrit0
Copy link
Contributor

Gerrit0 commented Jun 12, 2024

I had ideas I wanted to play with based off this viewer, but it looks like something doesn't work quite right anymore, this is with a fresh install, I gave Node 22 a try too, with the same issue

main ~/Desktop/ts-ast-viewer> node --version
v20.10.0
main ~/Desktop/ts-ast-viewer> deno --version
deno 1.44.1 3765e6b (canary, x86_64-unknown-linux-gnu)
v8 12.6.228.9
typescript 5.4.5
main ~/Desktop/ts-ast-viewer> deno task build
Task build DENO_V8_FLAGS=--max_old_space_size=10240 vite build && cp CNAME .nojekyll dist/
Warning Sloppy imports are not recommended and have a negative impact on performance.
vite v5.2.9 building for production...
✓ 72 modules transformed.
x Build failed in 441ms
error during build:
RollupError: Expected '}', got '<eof>'
    at getRollupError (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
    at ParseError.initialise (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/node-entry.js:11170:28)
    at convertNode (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/node-entry.js:12915:10)
    at convertProgram (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/node-entry.js:12232:12)
    at Module.setSource (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/node-entry.js:14076:24)
    at async ModuleLoader.addModuleSource (file:///home/gerrit/Desktop/ts-ast-viewer/node_modules/rollup/dist/es/shared/node-entry.js:18729:13)
exit 1
main ~/Desktop/ts-ast-viewer>

deno task test does run successfully (with lots of noise about "sloppy imports"), which implies I didn't set up deno incorrectly somehow...

I also tried following the steps laid out in ci.yml, with similar problems.... not really sure where to go from here. I miss the simple npm install && npm run build I used to be able to do.
@dsherret
Copy link
Owner

Use deno upgrade --version 1.44.1. It seems like a recent bug in deno canary.

I miss the simple npm install && npm run build I used to be able to do.

Sorry, I'm using this repo to find and fix bugs in Deno's upcoming 2.0 version.

@dsherret
Copy link
Owner

Seems to break on denoland/deno@e3b2ee1

@dsherret
Copy link
Owner

Fix at denoland/deno#24193

Will be able to close this with the Deno release tonight.

@dsherret
Copy link
Owner

This is passing again now: https://github.com/dsherret/ts-ast-viewer/actions/runs/9495212391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsherret @Gerrit0 and others