Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker setup guide for v2 #1369

Merged
merged 1 commit into from
Jul 15, 2024
Merged

docker setup guide for v2 #1369

merged 1 commit into from
Jul 15, 2024

Conversation

CluEleSsUK
Copy link
Contributor

No description provided.

Base automatically changed from feature/drand-v2.0.0 to master June 28, 2024 08:59
An error occurred while trying to automatically change base from feature/drand-v2.0.0 to master June 28, 2024 08:59
@CluEleSsUK CluEleSsUK changed the base branch from master to fix/sigdkg June 28, 2024 09:00
@CluEleSsUK CluEleSsUK changed the base branch from fix/sigdkg to master June 28, 2024 09:00
@CluEleSsUK CluEleSsUK changed the base branch from master to insecuretag June 28, 2024 09:03
@CluEleSsUK CluEleSsUK changed the base branch from insecuretag to master June 28, 2024 09:03
AnomalRoil
AnomalRoil reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should be using something like the "latest" tag for docker images?

Because otherwise we need to update all of these files with each new tagged release, no?

docker/README.md Show resolved Hide resolved
@CluEleSsUK
Copy link
Contributor Author

I’ve heard mixed views on the latest tag - some claim it’s an antipattern. Personally it makes sense to me but I wonder what @GlacierWalrus has to say on the matter

@AnomalRoil AnomalRoil linked an issue Jun 28, 2024 that may be closed by this pull request
update docker demo for v2 #1360
Closed
@GlacierWalrus
Copy link
Collaborator

I’ve heard mixed views on the latest tag - some claim it’s an antipattern. Personally it makes sense to me but I wonder what @GlacierWalrus has to say on the matter

Nothing wrong with us keeping a latest tag imo. latest is only a problem if you don't treat it with due care. I'm sure people have documented comprehensive reasons on their blogs about why you shouldn't use it, my strategy is only to use latest for non-serious applications.

@AnomalRoil AnomalRoil mentioned this pull request Jul 15, 2024
Open
@AnomalRoil AnomalRoil merged commit b340a0d into master Jul 15, 2024
75 of 79 checks passed
@AnomalRoil AnomalRoil deleted the fix/docker-setup-v2 branch July 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update docker demo for v2
3 participants
@CluEleSsUK @GlacierWalrus @AnomalRoil