Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding checkmarks to DKG status output #1362

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Adding checkmarks to DKG status output #1362

merged 4 commits into from
Jun 19, 2024

Conversation

AnomalRoil
Copy link
Member

Just to make it prettier and clearer who has accepted and who hasn't accepted yet.

@AnomalRoil
Copy link
Member Author

This now prints:


 ------------- ------------------------------ ----------------------------- 
| FIELD       | CURRENT                      | FINISHED                    |
 ------------- ------------------------------ ----------------------------- 
| Status      | Complete                     | Complete                    |
| Epoch       | 2                            | 2                           |
| BeaconID    | default                      | default                     |
| Threshold   | 5                            | 5                           |
| Timeout     | 2024-06-13T10:24:16Z         | 2024-06-13T10:24:16Z        |
| GenesisTime | 2024-06-12T10:23:46Z         | 2024-06-12T10:23:46Z        |
| GenesisSeed | <snip>                       | <snip>                      |
| Leader      | 127.0.0.1:45777              | 127.0.0.1:45777             |
| Joining     | [                            | [                           |
|             |     127.0.0.1:42427,         |      ☑ 127.0.0.1:42427,     |
|             |     127.0.0.1:46847,         |      ☒ 127.0.0.1:46847,     |
|             |     127.0.0.1:34459,         |      ☑ 127.0.0.1:34459,     |
|             | ]                            | ]                           |
| Remaining   | [                            | [                           |
|             |      ☑ 127.0.0.1:45777,      |      ☑ 127.0.0.1:45777,     |
|             |      ☑ 127.0.0.1:34565,      |      ☑ 127.0.0.1:34565,     |
|             |      ☑ 127.0.0.1:43127,      |      ☑ 127.0.0.1:43127,     |
|             |      ☑ 127.0.0.1:41179,      |      ☑ 127.0.0.1:41179,     |
|             |      ☑ 127.0.0.1:46745,      |      ☑ 127.0.0.1:46745,     |
|             | ]                            | ]                           |
| Leaving     | [    127.0.0.1:46239    ]    | [    127.0.0.1:46239    ]   |
| Accepted    | [                            | [                           |
|             |     127.0.0.1:34565,         |     127.0.0.1:34565,        |
|             |     127.0.0.1:43127,         |     127.0.0.1:43127,        |
|             |     127.0.0.1:41179,         |     127.0.0.1:41179,        |
|             |     127.0.0.1:46745,         |     127.0.0.1:46745,        |
|             | ]                            | ]                           |
| Rejected    | []                           | []                          |
| FinalGroup  |                              | [                           |
|             |                              |     127.0.0.1:43127,        |
|             |                              |     127.0.0.1:42427,        |
|             |                              |     127.0.0.1:34565,        |
|             |                              |     127.0.0.1:41179,        |
|             |                              |     127.0.0.1:45777,        |
|             |                              |     127.0.0.1:46745,        |
|             |                              |     127.0.0.1:34459,        |
|             |                              | ]                           |
 ------------- ------------------------------ -----------------------------

@CluEleSsUK
Copy link
Contributor

Hmm looking at the printed output we could maybe just get rid of the Accepted/Rejected rows now that we have cool checkmarks

CluEleSsUK
CluEleSsUK reviewed Jun 12, 2024
View reviewed changes
internal/core/util_test.go
@@ -401,7 401,7 @@ func (d *DrandTestScenario) RunDKG(t *testing.T) (*key.Group, error) {
d.AdvanceMockClock(d.t, d.nodes[0].daemon.opts.dkgKickoffGracePeriod)

t.Log("[RunDKG] WaitForDKG on leader")
groupFile, err := d.WaitForDKG(t, leader, 1, 100)
groupFile, err := d.WaitForDKG(t, leader, 1, 150)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempted flake combat? :p

@CluEleSsUK
Copy link
Contributor

Ahh the checkmarks in the Finished state represent whether they made it to the final group too, that's a nice touch

@CluEleSsUK CluEleSsUK merged commit ba2e4f2 into feature/drand-v2.0.0 Jun 19, 2024
64 checks passed
@CluEleSsUK CluEleSsUK deleted the dkg/prettycheckmarks branch June 19, 2024 14:51
@GlacierWalrus GlacierWalrus mentioned this pull request Jun 24, 2024
Open
CluEleSsUK pushed a commit that referenced this pull request Jun 28, 2024
@AnomalRoil @CluEleSsUK
Adding checkmarks to DKG status output (#1362)
ed8d477 
* Adding checkmarks to Remaining nodes in DKG status output
AnomalRoil added a commit that referenced this pull request Jun 28, 2024
@AnomalRoil
Adding checkmarks to DKG status output (#1362)
ee1a54e 
* Adding checkmarks to Remaining nodes in DKG status output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CluEleSsUK CluEleSsUK CluEleSsUK left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnomalRoil @CluEleSsUK