test for running lots of DKGs back to back #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CluEleSsUK
force-pushed
the
feature/drand-v2.0.0
branch
from
67f61f7
to
316544a
Compare
AnomalRoil
approved these changes
May 10, 2024
Comment on lines
511
to
513
| if n.Index() == leader.Index() || done[n.PublicAddr()] { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Can done[n.PublicAddr()] be true at any time in that loop? 😮
Are there duplicated nodes in except(e.reshareNodes[1:], e.newNodes)?
There was a problem hiding this comment.
for some reason this was failing - I didn't think there could be duplicate nodes, but this solved it
CluEleSsUK
force-pushed
the
feature/run-many-dkgs
branch
from
0b06063
to
3584fe9
Compare
CluEleSsUK
added a commit
that referenced
this pull request
Jun 28, 2024
* test for running lots of DKGs back to back * reduce period
AnomalRoil
pushed a commit
that referenced
this pull request
Jun 28, 2024
* test for running lots of DKGs back to back * reduce period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.