Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow DOTNET_SCRIPT_CACHE_LOCATION to be relative #699

Merged
merged 3 commits into from
Jan 31, 2023
Merged

allow DOTNET_SCRIPT_CACHE_LOCATION to be relative #699

merged 3 commits into from
Jan 31, 2023

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 31, 2023

If the path retrieved from DOTNET_SCRIPT_CACHE_LOCATION is not absolute, we will make it relative to the current folder.

Fixes #658

@filipw filipw requested a review from seesharper January 31, 2023 15:43
seesharper
seesharper approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍😃

@seesharper seesharper merged commit e1997aa into master Jan 31, 2023
@seesharper seesharper deleted the bugfix/cache-path branch January 31, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - DOTNET_SCRIPT_CACHE_LOCATION doesn"t work with relative path
2 participants
@filipw @seesharper