Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove CLSCompliant attribute (#12469)" #12477

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Nov 14, 2024

This reverts commit f7a5332.

Didn't realize the impact this would have upstream if dependencies were building as CLSCompliant.

Microsoft Reviewers: Open in CodeFlow

This reverts commit f7a5332.

Didn't realize the impact this would have upstream if dependencies were
building as CLSCompliant.
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.73313%. Comparing base (8dd924a) to head (e30751e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12477          /-   ##
===================================================
  Coverage   75.72275%   75.73313%    0.01037%     
===================================================
  Files           3153        3153                 
  Lines         635797      635797                 
  Branches       46973       46973                 
===================================================
  Hits          481443      481509          66     
  Misses        150919      150853         -66     
  Partials        3435        3435                 
Flag Coverage Δ
Debug 75.73313% <80.00000%> ( 0.01037%) ⬆️
integration 18.26827% <80.00000%> (-0.00212%) ⬇️
production 49.30569% <80.00000%> ( 0.02324%) ⬆️
test 97.05103% <ø> (ø)
unit 46.28573% <80.00000%> ( 0.02255%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JeremyKuhne JeremyKuhne merged commit 7d8f1af into dotnet:main Nov 14, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 14, 2024
@JeremyKuhne JeremyKuhne deleted the revertcls branch November 14, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants