Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage STARTUPINFO, SECURITY_ATTRIBUTES and PROCESS_INFORMATION from #11863 #12314

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Oct 12, 2024

Part of Fixes in #11863

Proposed changes

  • Improve test coverage for or STARTUPINFO New and SECURITY_ATTRIBUTES DRAFT

Customer Impact

  • Improve test coverage

Regression?

  • No

Risk

  • None, only adds tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55903%. Comparing base (f73363f) to head (a1772a4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12314          /-   ##
===================================================
  Coverage   75.55367%   75.55903%    0.00536%     
===================================================
  Files           3111        3114           3     
  Lines         635122      635159          37     
  Branches       46914       46916           2     
===================================================
  Hits          479858      479920          62     
  Misses        151803      151786         -17     
  Partials        3461        3453          -8     
Flag Coverage Δ
Debug 75.55903% <100.00000%> ( 0.00536%) ⬆️
integration 18.29826% <ø> ( 0.00177%) ⬆️
production 49.03755% <ø> ( 0.00880%) ⬆️
test 97.02456% <100.00000%> ( 0.00031%) ⬆️
unit 45.97827% <ø> (-0.01337%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@paul1956 paul1956 changed the title CodeCoverage for STARTUPINFO New and SECURITY_ATTRIBUTES DRAFT Code Coverage STARTUPINFO and SECURITY_ATTRIBUTES from #11863 DRAFT Oct 12, 2024
@paul1956 paul1956 changed the title Code Coverage STARTUPINFO and SECURITY_ATTRIBUTES from #11863 DRAFT Code Coverage STARTUPINFO and SECURITY_ATTRIBUTES from #11863 Oct 12, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would prefer dedicated files for each type, but this is a gray area, so I don't insist on it.

paul1956 and others added 2 commits October 14, 2024 13:23
…/Forms/NativeTypesTests.vb

Co-authored-by: Tanya Solyanik <[email protected]>
…/Forms/NativeTypesTests.vb

Co-authored-by: Tanya Solyanik <[email protected]>
@paul1956
Copy link
Contributor Author

Looks good. I would prefer dedicated files for each type, but this is a gray area, so I don't insist on it.

I will split this one and future ones.

@paul1956 paul1956 changed the title Code Coverage STARTUPINFO and SECURITY_ATTRIBUTES from #11863 Code Coverage STARTUPINFO, SECURITY_ATTRIBUTES and PROCESS_INFORMATION from #11863 Oct 15, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 7eaeb48 into dotnet:main Oct 15, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 15, 2024
@paul1956 paul1956 deleted the Code-Coverage-for-VB-NativeTypes-from-PR-#11863 branch October 16, 2024 07:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants