-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Coverage STARTUPINFO, SECURITY_ATTRIBUTES and PROCESS_INFORMATION from #11863 #12314
Code Coverage STARTUPINFO, SECURITY_ATTRIBUTES and PROCESS_INFORMATION from #11863 #12314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12314 /- ##
===================================================
Coverage 75.55367% 75.55903% 0.00536%
===================================================
Files 3111 3114 3
Lines 635122 635159 37
Branches 46914 46916 2
===================================================
Hits 479858 479920 62
Misses 151803 151786 -17
Partials 3461 3453 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would prefer dedicated files for each type, but this is a gray area, so I don't insist on it.
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/NativeTypesTests.vb
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/NativeTypesTests.vb
Outdated
Show resolved
Hide resolved
…/Forms/NativeTypesTests.vb Co-authored-by: Tanya Solyanik <[email protected]>
…/Forms/NativeTypesTests.vb Co-authored-by: Tanya Solyanik <[email protected]>
I will split this one and future ones. |
...sualBasic.Forms/tests/UnitTests/System/Windows/Forms/NativeTypesTests.PROCESS_INFORMATION.vb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Part of Fixes in #11863
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow