-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Network.VB into 7 Files from PR #11863 #12226
Split Network.VB into 7 Files from PR #11863 #12226
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12226 /- ##
====================================================
Coverage 49.20480% 75.63889% 26.43409%
====================================================
Files 1985 3147 1162
Lines 283954 635792 351838
Branches 41730 47010 5280
====================================================
Hits 139719 480906 341187
- Misses 141535 151440 9905
- Partials 2700 3446 746
Flags with carried forward coverage won't be shown. Click here to find out more. |
Reviewer note: coverage is identical to current unmodified code. The tests are in a separate PR #12221 . |
@KlausLoeffelmann there are no code changes in this PR, it just splits 1 large file into logical parts. Changes happen in follow on PR's. Having someone else do review might give you more time to work on other projects. |
@Tanya-Solyanik would it be possible to prioritize this PR over my others. It mostly splits 1 file into 7 using VS code fixes. There is also some cleanup of privates from m_name to _Name to follow updated .Net naming guidelines. It should be possible to eliminate most of the locals but that seemed to me like too big a change without the tests, which is a separate PR that is waiting for Klaus. |
src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/NetworkPing.vb
Outdated
Show resolved
Hide resolved
@lonitra network.vb being completely rewritten in PR #11863 to replace WebClient which is obsolete. There are 3 separate (independent) pieces of functionality (upload, download and ping), in PR #11863 Async functions are also added in a separate file (PR review will decide if they ever become public). This allows the changes to be more isolated and the reviews simpler. |
src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/NetworkAvailability.vb
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Network.UploadFile.vb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow