Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Network.VB into 7 Files from PR #11863 #12226

Merged
merged 31 commits into from
Oct 30, 2024

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 25, 2024

Proposed changes

  • Split Network.Vb in 7 files to prepare for replacement of WebClient for download

Customer Impact

  • Developer only improvement

Regression?

  • No

Risk

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 6.58784% with 553 lines in your changes missing coverage. Please review.

Project coverage is 75.63889%. Comparing base (d223c9e) to head (72a8f30).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12226           /-   ##
====================================================
  Coverage   49.20480%   75.63889%    26.43409%     
====================================================
  Files           1985        3147         1162     
  Lines         283954      635792       351838     
  Branches       41730       47010         5280     
====================================================
  Hits          139719      480906       341187     
- Misses        141535      151440         9905     
- Partials        2700        3446          746     
Flag Coverage Δ
Debug 75.63889% <6.58784%> ( 26.43409%) ⬆️
integration 18.23820% <0.00000%> (-0.01352%) ⬇️
production 49.16450% <6.58784%> (-0.04031%) ⬇️
test 97.03085% <ø> (?)
unit 46.14524% <6.58784%> (-0.04640%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@paul1956
Copy link
Contributor Author

Reviewer note: coverage is identical to current unmodified code. The tests are in a separate PR #12221 .

@paul1956 paul1956 changed the title Split Network.VB into 7 Files Split Network.VB into 7 Files from #118863 Sep 26, 2024
@paul1956 paul1956 changed the title Split Network.VB into 7 Files from #118863 Split Network.VB into 7 Files from PR #118863 Sep 26, 2024
@paul1956 paul1956 changed the title Split Network.VB into 7 Files from PR #118863 Split Network.VB into 7 Files from PR #11863 Sep 26, 2024
@paul1956
Copy link
Contributor Author

@KlausLoeffelmann there are no code changes in this PR, it just splits 1 large file into logical parts. Changes happen in follow on PR's. Having someone else do review might give you more time to work on other projects.

@paul1956
Copy link
Contributor Author

@Tanya-Solyanik would it be possible to prioritize this PR over my others. It mostly splits 1 file into 7 using VS code fixes. There is also some cleanup of privates from m_name to _Name to follow updated .Net naming guidelines. It should be possible to eliminate most of the locals but that seemed to me like too big a change without the tests, which is a separate PR that is waiting for Klaus.

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Oct 25, 2024
@paul1956
Copy link
Contributor Author

paul1956 commented Oct 25, 2024

@lonitra network.vb being completely rewritten in PR #11863 to replace WebClient which is obsolete. There are 3 separate (independent) pieces of functionality (upload, download and ping), in PR #11863 Async functions are also added in a separate file (PR review will decide if they ever become public). This allows the changes to be more isolated and the reviews simpler.

@dotnet-policy-service dotnet-policy-service bot added untriaged The team needs to look at this issue in the next triage and removed 📭 waiting-author-feedback The team requires more information from the author labels Oct 25, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed untriaged The team needs to look at this issue in the next triage labels Oct 28, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 28, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 29, 2024
@lonitra lonitra merged commit 781a7fb into dotnet:main Oct 30, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 30, 2024
@paul1956 paul1956 deleted the Split-Network.vb-inlo-logical-parts branch October 31, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants