Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FUSE] Folding range whitespace differences at the end of blocks #10860

Open
davidwengier opened this issue Sep 9, 2024 · 3 comments
Open

[FUSE] Folding range whitespace differences at the end of blocks #10860

davidwengier opened this issue Sep 9, 2024 · 3 comments
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Milestone
17.13 P2

Comments

@davidwengier
Copy link
Contributor

davidwengier commented Sep 9, 2024 •
edited
Loading

Not sure if this is a tooling issue, or difference in results from Roslyn caused by a runtime/designtime compilation difference.

Example differences:
image

From:
f929020?diff=unified&w=0#diff-a1706b971c83e9c0c358e3db52e305ad63a07dc5a88c23d2ae265ce9e06eaf54L30

I think this is a bad user experience as, in the example above, the closing div tag would end up displayed on the same line as the @if when collapsed.
davidwengier added a commit that referenced this issue Sep 10, 2024
@davidwengier
Fix, skip or update tooling tests
f929020 
Skipped folding range test tracked by #10859
Skipped rename test tracked by #10856
Updated semantic tokens test tracked by #10857
Update folding range tests tracked by #10860
Update spell checking test tracked by #10863
Skipped formatting tests tracked by #10864
Skipped auto insert tests tracked by #10865
@phil-allen-msft phil-allen-msft added New Feature: Fuse area-compiler Umbrella for all compiler issues labels Sep 12, 2024
@davidwengier
Copy link
Contributor Author

davidwengier commented Oct 3, 2024 •
edited
Loading

#10959 marks an integration test as skipped referencing this issue. Please unskip when fixing :)

@jaredpar
Copy link
Member

jaredpar commented Oct 8, 2024

@chsienki

@chsienki
Copy link
Contributor

chsienki commented Oct 8, 2024

@jaredpar Yep, I mentioned this one previously. We've been fixing these on an ad-hoc basis but it turns out it's an issue with any @ directive that razor parses directly.

I plan to fix that holistically rather than doing more one at a time patches, but we're getting into the long tail of what users actually see so not considering this a blocker for fuse rollout right now.

(Aside, apologies I guess I didn't put these issues into milestones but have already triaged them).

@chsienki chsienki added this to the 17.12 P3 milestone Oct 8, 2024
@phil-allen-msft phil-allen-msft modified the milestones: 17.12 P3, 17.13 P2 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Projects
None yet
Milestone
17.13 P2
Development

No branches or pull requests
4 participants
@jaredpar @davidwengier @chsienki @phil-allen-msft