Improve doc in IAuthenticationHandler #56196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekistler
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
halter73
approved these changes
Jun 11, 2024
src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Jun 11, 2024
src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Jun 11, 2024
src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Halter <[email protected]>
|
@halter73 I think the fix is even easier than what I first proposed -- we just need to make clear that the HttpContext passed to InitializeAsync is for the "current request". Take a look at my new commit and let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify "current request" in method descriptions in IAuthenticationHandler
Clarified that the "current request" was passed to the InitializeAsync and thus stored within the instance somewhere.
Description
I think the prior wording was confusing because the methods in question take no parameter, so it was unclear how the method determined the "current request".
No issue opened, as that would have doubled the work required for this small change.