[release/7.0] Tweak publishing to avoid clearing ItemsToPush during SB #43946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
|
@dougbu I think this may be the fix. |
dougbu
approved these changes
Sep 13, 2022
|
Before merging, let's have a look at the artifacts of the CI build to make sure this was the only problem w/ source-build. The other option would be to do a manual internal build (w/o tests) and check the source-build manifest file. |
|
I think DotNetBuildFromSource is not actually set in the inner build, so I'll need to find a different property. |
dougbu
reviewed
Sep 13, 2022
|
Test build worked 😄 Package was published and manifest contains <Package Id="Microsoft.SourceBuild.Intermediate.aspnetcore" Version="7.0.0-rc.2.22463.4" NonShipping="true" />
<Blob Id="assets/symbols/Microsoft.SourceBuild.Intermediate.aspnetcore.7.0.0-rc.2.22463.4.symbols.nupkg" NonShipping="true" /> |
|
yep. Updating comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.