Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fast publishing #43788

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Enable fast publishing #43788

merged 1 commit into from
Sep 7, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 7, 2022

Eliminates the "Publish Using Darc" stage altogether, moving the call to publishing at the end of the Publish To Build Asset Registry job.

This eliminates 10ish minutes of overhead.

Also remove a bunch of unused variables.

@mmitche mmitche requested review from a team, dougbu and wtgodbe as code owners September 7, 2022 00:31
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 7, 2022
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dougbu
Copy link
Member

dougbu commented Sep 7, 2022

This PR reminded me of a hack we've had in release/6.0 for a while. Is the following still needed (or was the right Arcade fix backported)❔
https://github.com/dotnet/aspnetcore/blob/release/6.0/eng/helix/helix.proj#L59-L74

@mmitche
Copy link
Member Author

mmitche commented Sep 7, 2022

This PR reminded me of a hack we've had in release/6.0 for a while. Is the following still needed (or was the right Arcade fix backported)❔ https://github.com/dotnet/aspnetcore/blob/release/6.0/eng/helix/helix.proj#L59-L74

Probably not required for main, but should be backported so that we don't need to make the same change again when we branch for 8.0.

@mmitche mmitche merged commit e40c0fd into dotnet:main Sep 7, 2022
@ghost ghost added this to the 8.0-alpha1 milestone Sep 7, 2022
@dougbu
Copy link
Member

dougbu commented Sep 8, 2022

but should be backported so that we don't need to make the same change again

The underlying problem was not fixed in Arcade❔ I thought it was and believe we would have hit problems during the stabilization exercise if that were not the case. (The hack is present only in our release/6.0 branch.)

My question was therefore about backporting the Arcade fix to the Arcade release/6.0 branch and removing this hack. After hunting a bit, I see the only difference between FindDotNetCliPackage in release/6.0 and release/7.0 is the default feeds, everything from release/6.0 on checks both "dotnetcli" and "dotnetbuilds" feeds. I think we'd be 🆗 w/o the hack and will try an internal build removing it soon.

@mmitche
Copy link
Member Author

mmitche commented Sep 8, 2022

I'm not sure...maybe it got fixed in arcade? @MattGal does this ring a bell? https://github.com/dotnet/aspnetcore/blob/release/6.0/eng/helix/helix.proj#L59-L74

@ghost
Copy link

ghost commented Sep 8, 2022

Hi @mmitche. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@dougbu
Copy link
Member

dougbu commented Sep 8, 2022

/fyi @chcosta fixed Arcade in dotnet/arcade@36d37f1 then dotnet/arcade@2580afb

Yeah, I should have looked closely at Arcade first. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants