Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Apollo features in the useCSRFPrevention plugin #3142

Closed
holzerch opened this issue Dec 16, 2023 · 3 comments
Closed

Support all Apollo features in the useCSRFPrevention plugin #3142

holzerch opened this issue Dec 16, 2023 · 3 comments

Comments

@holzerch
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The description of the useCSRFPrevention plugins claims it would mimic the Apollo Server functionality. But actually Apollo does a lot more checks incl. checking the value of the content-type header. So when migrating from Apollo the plugin is not usable as a replacement.

Describe the solution you'd like

If would be great if you could replicate the functionality of the Apollo Server: See

Describe alternatives you've considered

I am writing a my own plugin at moment

@EmrysMyrddin
Copy link
Collaborator

Hi! Thank you for your report 😃
Do you mean your are creating your own CSRF plugin for yoga ?
If you are, don't hesitate to open a PR to enhance our existing one if it doesn't actually suite your needs :-) New contributors are very welcome, don't hesitate to ask here if you have question or need help for your implementation.

@holzerch
Copy link
Contributor Author

@EmrysMyrddin here you go #3146

@holzerch
Copy link
Contributor Author

holzerch commented Jan 1, 2024

Fixed with #3146

@holzerch holzerch closed this as completed Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants