-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateTime, Date, Time, JSON - scalars proposal #30
Comments
I think there's definitely value in supporting a common set of schema definitions type resolvers as a standalone package (which then could be used by I remember @RomanGotsiy and @IvanGoncharov coming up with the same idea. Would be great to hear their thoughts! |
We still have this idea and to release such package. However, it blocked by graphql/graphql-spec#326 since if you define custom scalars without specifying underlying serialization type you create a lot of problems for tooling and especially for code generation. |
@IvanGoncharov as I guess its still a draft implementation and I think we can add those scalars today and describe serialization type for them when it will be possible and stable. |
There's already |
@kbrandwijk my proposal was just to use already implemented scalars and put the in graphql-yoga out of the box. |
@playerx Yes, and I completely agree with that. My response was more for @IvanGoncharov who mentioned releasing another package like that. |
This is also related to prisma-labs/prisma-binding#15 |
@kbrandwijk In graphql-js As for package I planning to do I have a few very specific features in mind not sure if it will work like intended but I will try 😄 |
Due to inactivity of this issue we have marked it |
Due to inactivity of this issue we have marked it |
Due to inactivity of this issue we have marked it |
Hey 👋, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of |
Hey, @Urigo from The Guild here! You might know us from projects such as graphql-code-generator, envelop or graphql-tools. For a long time we thought that the Javascript ecosystem is still missing a lightweight cross-platform, but still highly customizable GraphQL Server. In the past the awesome Prisma team took on that great challenge and now we are happy to announce that we are continuing them and just released GraphQL Yoga 2.0 - Build fast, extensible, and batteries-included (Subscriptions, Serverless, File uploads support) GraphQL APIs in Node.js 🚀 And regarding the issue here, we also maintain the GraphQL Scalars library We have been working a long time on version 2.0 and have been using it in our clients projects for a few months now and shared a couple of alpha cycles here. Please try Yoga out again, give us feedback and help us spread the word on the new release! |
What do you think to add those scalars out of the box:
DateTime, Date, Time, JSON
and make it configurable to disable them.
I think I will need them in all of my apps, especially DateTime.
If you think it's good idea I can send PR.
The text was updated successfully, but these errors were encountered: