Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support async filters #2290

Closed
n1ru4l opened this issue Jan 5, 2023 · 0 comments · Fixed by #2291
Closed

support async filters #2290

n1ru4l opened this issue Jan 5, 2023 · 0 comments · Fixed by #2291
Assignees
@n1ru4l

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 5, 2023

See #2289

We should allow returning a Promise from filter and await it in the implementation.

graphql-yoga/packages/subscription/src/operator/filter.ts

Line 22 in 6f40256

if (filter(latest.value)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1ru4l n1ru4l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support returning a Promise from the filter utility function dotansimha/graphql-yoga
1 participant
@n1ru4l