Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client-preset): custom suffix with namingConvention #10013

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(client-preset): custom suffix with namingConvention #10013

wants to merge 1 commit into from

Conversation

hecticme
Copy link

@hecticme hecticme commented Jun 19, 2024 •
edited

Description

When handling anonymous operation name, BaseDocumentsVisitor calls the convertName() method twice. This leads to duplicated suffix if a user provide a custom namingConvention function.

Related #10012

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

https://stackblitz.com/edit/gql-codgen-13f1zd

image

How Has This Been Tested?

I have described the problem in the related issue. The test added in this PR will reflect that.

Test Environment:

  • OS: Linux 6.8 Fedora Linux 40 (Workstation Edition)
  • NodeJS: 20.14.0
  • graphql version: 16.8.2
  • @graphql-codegen/cli version: 5.0.2

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

The main problem that I want to address is that the operation name does not match with itself inside Typed Document Node.

@hecticme
test(client-preset): operation names with custom suffix
96c2667 
This commit added a test case to make sure the generated operations' name is correct when the user specifies a `namingConvention` function.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2024 •
edited

⚠️ No Changeset found

Latest commit: 96c2667

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hecticme hecticme force-pushed the fix/redundant-operation-suffix branch from 1da7246 to 96c2667 Compare June 21, 2024 08:21
@hecticme hecticme changed the title fix: redundant operation name conversion test(client-preset): custom suffix with namingConvention Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hecticme