Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in HistoricalSignal #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed bug in HistoricalSignal #232

wants to merge 1 commit into from

Conversation

kilianp14
Copy link
Contributor

When querying forecast in the HistoricalSignal using bfill, np.nan is returned if there is no data point available to fill back the data.
Performing queries with other resample methods now works as expected when forecast range is exceeded (closes #229)

Copy link
Contributor

@marvin-steinke marvin-steinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congrats on your last PR haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resampling in HistoricalSignal.forecast off by 1 if outside available forecast data
3 participants