Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ess): update ess module #6455

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

refactor(ess): update ess module #6455

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d5172a0
feat(ess): add company-R-library backend
maikol-solis Jun 13, 2022
0c61a6d
feat(ess): add proper indentation with roxygen
maikol-solis Jun 26, 2022
8c5571f
nit(ess): reformat keybinds
maikol-solis Jun 26, 2022
8ff8b52
feat(ess): add lsp-mode client for TRAMP projects
maikol-solis Oct 2, 2022
d75c1ed
feat(ess): deprecate ess-R-data-view
maikol-solis Feb 28, 2023
447a19e
feat(ess): add ess-r-insert-obj package
maikol-solis Jul 24, 2022
f29b310
perf(ess): make REPL *R* buffer more responsive
maikol-solis Oct 2, 2022
f321e64
feat(ess): auto-detect more modes
maikol-solis Oct 2, 2022
ee5519f
feat(ess): add quarto-mode
maikol-solis Oct 5, 2022
a85afd4
nit(ess): reformat ESS mode section
maikol-solis Oct 3, 2022
d1c8666
feat(ess): enable company/corfu completions
maikol-solis Nov 18, 2022
0628505
feat(ess): corfu completions to the REPL buffer
maikol-solis Dec 2, 2022
b8ad0e7
bump: :lang ess
maikol-solis Apr 16, 2023
d9ceb4d
fix(ess): add company backends to inferior mode
maikol-solis Apr 28, 2023
f5a8fd0
fix(ess): pin packages
maikol-solis Jul 25, 2023
8b30327
bump: :lang ess
maikol-solis Jul 25, 2023
d4ca850
fix(ess): remove unnecessary cape config
maikol-solis Nov 24, 2023
5b13797
bump: :lang ess
maikol-solis Mar 9, 2024
2876128
fix(ess): return a repl instead of a buffer
maikol-solis May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(ess): add lsp-mode client for TRAMP projects
  • Loading branch information
@maikol-solis
maikol-solis committed Jan 13, 2025
commit 8ff8b523758c005e0e84d4130df65d1d29ee8858
15 changes: 15 additions & 0 deletions modules/lang/ess/config.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@
(when (modulep! +tree-sitter)
(add-hook 'ess-r-mode-local-vars-hook #'tree-sitter! 'append))

;; WAIT lsp-mode over TRAMP needs manual configuration, and still it doesn't
;; work (see https://github.com/emacs-lsp/lsp-mode/issues/3579). In eglot
;; remote buffers should work out the box.
;;
;; The problem and the fix it is already known by the lsp-mode devs. So we
;; must be patient. The expected configuration should be something like this:

(after! lsp-mode
(lsp-register-client
(make-lsp-client
:new-connection (lsp-stdio-connection '("R" "--slave" "-e" "languageserver::run()"))
:major-modes '(ess-r-mode)
:remote? t
:server-id 'lsp-r-remote)))
Comment on lines +58 to +71
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With lsp-auto-register-remote-clients added (and set to t by default) in emacs-lsp/lsp-mode@d45aca0, is this needed anymore?


(set-repl-handler! 'ess-r-mode #'+ess/open-r-repl)
(set-repl-handler! 'ess-julia-mode #'+ess/open-julia-repl)
(set-lookup-handlers! '(ess-r-mode ess-julia-mode)
Expand Down