Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ess): update ess module #6455

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

refactor(ess): update ess module #6455

wants to merge 19 commits into from
119 −61

Conversation

maikol-solis
Copy link
Contributor

For the moment, this is just a draft. Any contribution is welcome. A list of initial ideas are in this post.

Fixes #0000
References #0000
Replaces #0000

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@maikol-solis maikol-solis marked this pull request as ready for review June 14, 2022 15:37
@maikol-solis maikol-solis marked this pull request as draft June 14, 2022 15:42
@maikol-solis maikol-solis force-pushed the ess-refactor branch 3 times, most recently from 33ae832 to a012434 Compare June 17, 2022 20:29
@maikol-solis maikol-solis mentioned this pull request Jun 17, 2022
Closed
@maikol-solis maikol-solis changed the title feat(ess): refactor module refactor(ess): update ess module Jun 19, 2022
@maikol-solis maikol-solis force-pushed the ess-refactor branch 3 times, most recently from 26aa328 to 5d1867d Compare June 26, 2022 23:10
@hlissner hlissner added module:lang/ess Pertains to Doom's :lang ess module ! Introduces, suggests, or requires a backwards-incompatible change is:refactor Code changes with little/no effect on user-facing behavior labels Jun 27, 2022
hlissner
hlissner requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the other review requests further below, please make the following changes to the commit history (to conform with our git conventions):

  • About 5175cf5, if ess-view-data is a drop-in replacement for ess-R-data-view, then it should be a refactor, not a feat. If it isn't a drop-in replacement, it should be a breaking refactor: refactor!(ess): ... (see https://discourse.doomemacs.org/t/git-conventions/2407#breaking-changes-7)
  • Another thing about 5175cf5: since you are replacing a package, please add a package diff line to your commit message: 
    feat(ess): deprecate ess-R-data-view

myuhe/ess-R-data-view.el@d6e98d3ae1e2 -> ShuguangSun/ess-view-data@6277684e06d5

Use `ess-view-data` given the extensive support for multiple backends
like base, dplyr, DT, kable, etc. Also, it seems that `ess-R-data-view`
is in an unmaintained/stale state.
  • Reword 7836412 to nit(ess): reformat keybinds, to be more specific.
  • Change cfae4b0 to perf(ess): ...; if it is indeed a change made solely to improve performance.

modules/lang/ess/config.el Outdated Show resolved Hide resolved
modules/lang/ess/config.el Outdated Show resolved Hide resolved
modules/lang/ess/config.el Outdated Show resolved Hide resolved
@maikol-solis
Copy link
Contributor Author

Thanks @hlissner for all your suggestions. I fixed all the problems in the commits.
In the next days, I will experiment with other fixes in the module.

@maikol-solis maikol-solis force-pushed the ess-refactor branch 4 times, most recently from 84bed8d to 89f19fb Compare August 5, 2022 16:54
@maikol-solis maikol-solis force-pushed the ess-refactor branch 2 times, most recently from d246e1b to 8c01c56 Compare August 17, 2022 15:22
@maikol-solis maikol-solis force-pushed the ess-refactor branch 2 times, most recently from 9339249 to 8fc90c6 Compare September 13, 2022 16:13
@maikol-solis maikol-solis force-pushed the ess-refactor branch 2 times, most recently from e9ef649 to 1376bfa Compare November 20, 2024 10:53
@KaiAragaki
Copy link

Something to keep on the lookout - posit is creating a LSP (air: https://github.com/posit-dev/air) that uses Rust (🚀 ) which may become the preferred language server in the future.

@maikol-solis maikol-solis force-pushed the ess-refactor branch 3 times, most recently from 2300de1 to d6bbc9c Compare January 11, 2025 23:36
@maikol-solis
feat(ess): add company-R-library backend
d5172a0
@maikol-solis
feat(ess): add proper indentation with roxygen
0c61a6d
@maikol-solis
nit(ess): reformat keybinds
8c5571f 
fix: temp help after ess
@maikol-solis
feat(ess): add lsp-mode client for TRAMP projects
8ff8b52
@maikol-solis
feat(ess): deprecate ess-R-data-view
d75c1ed 
myuhe/ess-R-data-view.el@d6e98d3ae1e2 -> ShuguangSun/ess-view-data@6277684e06d5

Use `ess-view-data` given the extensive support for multiple backends
like base, dplyr, DT, kable, etc. Also, it seems that `ess-R-data-view`
is in an unmaintained/stale state.
@maikol-solis
feat(ess): add ess-r-insert-obj package
447a19e 
Utilities to help inserting variable (column) names or values in ESS.
@maikol-solis
perf(ess): make REPL *R* buffer more responsive
f29b310
@maikol-solis
feat(ess): auto-detect more modes
f321e64 
Include more file extension that work with ESS and their respective
commands.
@maikol-solis
feat(ess): add quarto-mode
ee5519f
@maikol-solis
nit(ess): reformat ESS mode section
a85afd4
@maikol-solis
feat(ess): enable company/corfu completions
d1c8666 
Now the module is aware of if the completion system is company or corfu.
@maikol-solis
feat(ess): corfu completions to the REPL buffer
0628505
@maikol-solis
bump: :lang ess
b8ad0e7 
emacs-ess/ESS@8b4664e4a76a -> emacs-ess/ESS@3bff8e738c88
polymode/polymode@15b6c1e94a45 -> polymode/polymode@ca060e081a1f
@maikol-solis
fix(ess): add company backends to inferior mode
d9ceb4d 
Fix: doomemacs#7205
@maikol-solis
fix(ess): pin packages
f5a8fd0
@maikol-solis
bump: :lang ess
8b30327 
ShuguangSun/ess-view-data@6277684e06d5 -> ShuguangSun/ess-view-data@c0b20e503c77
quarto-dev/quarto-emacs@151016ec224a -> quarto-dev/quarto-emacs@a7b974f7d22e
@maikol-solis
fix(ess): remove unnecessary cape config
d4ca850
@maikol-solis
bump: :lang ess
5b13797 
ShuguangSun/ess-view-data@c0b20e503c77 -> ShuguangSun/ess-view-data@c077741bc338
emacs-ess/ESS@5c4ae91cefa5 -> emacs-ess/ESS@cf2372530495
@maikol-solis
fix(ess): return a repl instead of a buffer
2876128 
Fix: doomemacs#6235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
! Introduces, suggests, or requires a backwards-incompatible change is:refactor Code changes with little/no effect on user-facing behavior module:lang/ess Pertains to Doom's :lang ess module
Projects
None yet
Milestone
modules backlog
Development

Successfully merging this pull request may close these issues.

Inferior ess mode very slow with company repl related bindings not working in ess
5 participants
@maikol-solis @mschilli87 @hlissner @KaiAragaki @edvinsyk