Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent config files conventions #2199

Closed
mtarnovan opened this issue May 16, 2016 · 4 comments
Closed

Inconsistent config files conventions #2199

mtarnovan opened this issue May 16, 2016 · 4 comments
Labels
needs: more info type: enhancement
Milestone
v0.7.0

Comments

@mtarnovan
Copy link

Currently some config files are picked up from the app repo (e.g. DOKKU_SCALE), while others must be places on the server in $DOKKU_HOME/$APP (e.g. DOCKER_OPTIONS_*). While it's debateable which is the right place™ to keep these files, it seems arbitrary to handle them differently.

In my opinion all these files should be picked up from the app repo, and DOCKER_OPTIONS_* should be renamed to DOKKU_DOCKER_OPTIONS_*.
@michaelshobbs
Copy link
Member

Context:
The app repo convention comes from Heroku and is required (i.e. Procfile). The $DOKKU_ROOT/$APP placement was picked lazily and arbitrarily as a location to store app configuration. For example, you'll notice that ENV is also stored there. We have an open issue for moving app config out of the app dir.

To clarify on your second point, you are referring to the filenames, correct?

Also, PRs are welcomed.

@josegonzalez
Copy link
Member

@mtarnovan Can you answer the question posed by @michaelshobbs?

@mtarnovan
Copy link
Author

Correct, I'm referring to the filenames.

@josegonzalez josegonzalez added this to the v0.7.0 milestone Jun 24, 2016
@josegonzalez josegonzalez mentioned this issue Jul 2, 2016
Open
@josegonzalez
Copy link
Member

Closing in favor of #1558. I've added a note to the generic spec to name things properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: more info type: enhancement
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
3 participants
@mtarnovan @josegonzalez @michaelshobbs