-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No background color for nvim #39
Comments
What's the issue that it causes?
This, a terminal emulator?
What is |
The plug doesn't have background colors set for neovim, so there is some kind of default background (I can work around it by setting
Yes that's the one
A lightweight compositor for X11, so not having a background set results in the transparency of nvim |
I understand that the background doesn't have colors being set. I don't understand how not having the background color set is an issue. Does it make the text unreadable or something else? Providing a screenshot would help. Also what's your environment?
|
Okay, now I see why that is an issue. I've got a few things that I'd like to finish before I look into this issue. Sounds like you've got a manual work around for the time being. Feel free to submit a contribution (might be a while until I can look at it though). |
Hi! At the moment, I can't install alacritty & picom to test it out myself. However, if you're using picom, you shouldn't be setting transparency with that, at least for alacritty. Instead, Alacritty has a built-in transparency feature, which is independent of any compositor. In the config file for Alacritty, you can add something similar to this:
the You can try it out and share your results here. |
@mlc-d Seems like the problem is not alacritty, nor using picom. It's just that the the themes are missing a background color and so the default background color of the given terminal emulator is used instead. The background colors should be defined so that the themes are consistent between different terminal emulator configurations. |
@sproott you're absolutely right. There's an unused variable
However, I didn't send the PR because there are some side effects. It looks like For example, if I set the theme neovim running on a terminal emulator (alacritty) on the right. On the left, the Neovim-GTK app. Another example, the theme So far, with Neovim-GTK it works great, no color/contrast problems whatsoever; but with proper terminal emulators (konsole, alacritty, gnome-terminal, etc), the problem persists. I might send the PR with the corrections I made looking at each theme, but the issue with the font falling back to tty's default still exists @Unthrottled |
@mlc-d could you make your current work on this public?, I have some time to give it a try and get this working. |
Hi, i was gonna use your themes for neovim, but i found out that the background colors might not be set. Also when i use picom for background transparency with alacritty, the background for your themes in neovim is also transparent which shouldn't be.
The text was updated successfully, but these errors were encountered: