Manual revert of 423 #444
Merged
Manual revert of 423 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #444 /- ##
==========================================
Coverage 43.16% 43.54% 0.37%
==========================================
Files 12 12
Lines 885 875 -10
Branches 271 265 -6
==========================================
- Hits 382 381 -1
Misses 503 494 -9
Continue to review full report at Codecov.
|
agubler
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #423
This PR manually reverts #423.
This code has been found to cause issues with image urls in css files where the final path from the html file requesting the image differs from the widget ts file that creates it.
For example in a BTR environment with a webpage created at
src/pages/ClientA.tsxrequiring a css file fromsrc/pages/ClientA.m.css.When the BTR site is build, in this case, the clientA page is now at
/clients/clientA.htmland the relative image path from the css file now resolves to/src/pages/images/clientABackground.jpgwhich is incorrect.This approach will always cause us problems where the widget resulting in a webpage is not served in the same relative directory structure as the source files. This becomes further more problematic in circumstances where you may have a widget requiring css images served in multiple locations.
We must revisit #314 #315 when this has been reverted.