Fix loading images from code split CSS and maintain dev structure/remove hashes from all dev assets #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
approved these changes
Aug 17, 2020
This was referenced Aug 17, 2020
Closed
Merged
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug / feature
The following has been addressed in the PR:
prettierDescription:
@matt-gadd This is basically the original solution I tried to implement for these issues that keeps the folder structure for all files and removes the hashes that were being included in some files in dev. The difference is the addition of a dependency on a plugin that resolves the issues we were running into with asset paths in css
url()s for code split files and dynamic public paths.Resolves #314 #315