Ensure code format #2138
Merged
Ensure code format #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…private methods and properties to start to encapsulate Docsify Also some small tweaks: - move initGlobalAPI out of Docsify.js to start to encapsulate Docsify - move ajax to utils folder - fix some type definitions and improve content in some JSDoc comments - use concise class field syntax - consolidate duplicate docsify-ignore comment removal code This handles a task in [Simplify and modernize Docsify](#2104), as well as works towards [Encapsulating Docsify](#2135).
…rettier script for manually formatting the whole code base
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trusktr
force-pushed
the
ensure-code-format
branch
from
7ecb4be
to
3bef45b
Compare
17 tasks
Koooooo-7
changed the base branch from
move-private-functions-properties-into-classes
to
develop
Koooooo-7
reviewed
Aug 9, 2023
Koooooo-7
previously approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're using prettier, so ensure we check code format as part of the
lintscript. Also add aprettierscript for manually formatting the whole code base.The issue and pull request templates needed formatting, so I went ahead and made some updates at the same time. This PR is now using the updated PR template.
Related issue, if any:
Part of
Continues from PR
What kind of change does this PR introduce?
Build-related changes
Repo settings
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: