Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add notes on "hash" vs "history" routing in the config docs #1970

Merged
merged 5 commits into from
Jul 16, 2023

Conversation

trusktr
Copy link
Member

@trusktr trusktr commented Jan 23, 2023

Summary

expand routerMode docs.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 5:18pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61c9e4b:

Sandbox Source
docsify-template Configuration

@sy-records sy-records changed the title add notes on "hash" vs "history" routing in the config docs docs: add notes on "hash" vs "history" routing in the config docs Jan 23, 2023
@Koooooo-7
Copy link
Member

Maybe we could handle this config internally as a default alias config for sidebar and navbar instead of forcing user to config it manually .

@trusktr
Copy link
Member Author

trusktr commented Jan 26, 2023

@Koooooo-7 I think that may be possible, but I think it might be a breaking change, and would need to be something we plan for a following major.

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trusktr
Copy link
Member Author

trusktr commented Jul 16, 2023

@Koooooo-7 tracking that ^ issue in #2133

@trusktr trusktr merged commit 4e01f4d into develop Jul 16, 2023
7 checks passed
@trusktr trusktr deleted the update-routerMode-docs branch July 16, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants