Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LXQT #2525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LXQT #2525

wants to merge 2 commits into from

Conversation

zxvv
Copy link
Contributor

@zxvv zxvv commented Apr 10, 2016

This adds the target: lxqt

It consists of lxqt, lxqt-common and dependent packages which are ~32MB installed.

These packages are available only on ubuntu vivid and xenial currently.

It depends on gtk-extra for a browser.

@zxvv
Copy link
Contributor Author

zxvv commented Apr 10, 2016

I removed the gtk-extra dependency, because lxde includes qupzilla, which is webkit based.

The installed size is ~1GB, due to the included apps.

The memory usage is relatively lean. Roughly 10MB more than XFCE.
The default theme has a flat color palette.

In addition to ubuntu vivid and xenial, it's also available in debian stretch and sid.

@DennisLfromGA
Copy link
Collaborator

@zxvv - I may try this out, lxde is currently my go-to desktop so this should work out well for me.

@dnschneid
Copy link
Owner

Thanks! Can you please rebase (or squash) this branch to get rid of the extra commits and reverts?

Also, at a minimum this target should depend on x11.

The currently supported releases in crouton are: wheezy jessie stretch sid kali-rolling precise trusty. If any of these don't support lxqt, you need to add some checking code like in the e17 target.

@zxvv
Copy link
Contributor Author

zxvv commented May 1, 2016

I squashed the commits,
added x11 as a dependency,
and validate the release prior to install.

Just let me know if anything needs attention!


if [ "${TARGETNOINSTALL:-c}" = 'c' ]
if [ "${ARCH#arm}" != "$ARCH" ]; then
error 99 "Mate packages are not available for ARM."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these checks correct? First of all, it's LXQT. Secondly, some of the text doesn't match the check (Xenial/Trusty). Thirdly, are you sure there's no ARM builds of LXQT? It's not like you're adding a repo or anything...

@zxvv
Copy link
Contributor Author

zxvv commented May 2, 2016

My intention was for the install to succeed for trusty, xenial and later, as well as, for stretch and later.
Those are the releases that have LXQT in the bundled repos.
If that's not what the tests are doing then yes, I've misunderstood what 'release -lt' means.

There are arm64 builds, but there are none for arm.

Thanks for catching the "Mate", that was wrong and should have been LXQT.
I fixed test test to exlude 'arm' arch (only) and fixed the "LXQT" in the error messages.
Please let me know if I've misunderstood something about the tests!

@zxvv
Copy link
Contributor Author

zxvv commented May 5, 2016

I have misunderstood the names for the various arm architectures.

xfce4 is available for arm64, armel and armhf.
likewise, lxde, lxqt and mate are available for arm64, armel and armhf.

I think this means lxde, etc., should be available on ARM just as xfce4 is.
So I'll remove the code that exclude install on "ARM" target for LXQT and Mate.

@zxvv
Copy link
Contributor Author

zxvv commented May 5, 2016

OK, with this commit, it installs on ARM now as discussed above.
Please let em know if you see any issues!

omit unnecessary lxqt-desktop. no additional apps are provided to lxqt as it stands.
Added required openbox package.  Revised isntall size.
omit gtk-extra dependency, becasuse qupzilla is included in lxde.
depend on x11. validate release prior to install.
allow install on ARM.

if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then
if release -lt trusty; then
error 99 "LXQT packages are not available for Ubuntu releases prior to xenial."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusty or xenial?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, trusty.
Prior to trusty, lxqt is not available at all as far as I've been able to find.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I think the text needs to be fixed, then.

@dnschneid dnschneid mentioned this pull request Jun 21, 2016
@dnschneid dnschneid mentioned this pull request Aug 24, 2016
@tsimonq2
Copy link

Bump, I'm the person working on Lubuntu's LXQt transition, it would be good to have this for my own testing and for when we actually make the transition.

@dnschneid
Copy link
Owner

@tsimonq2 if you fork @zxvv's branch and fix the testing errors, you could submit a PR with your fixups on top of @zxvv's commits.

@tsimonq2
Copy link

tsimonq2 commented Sep 1, 2016

@dnschneid Sure, I'll fork it over the weekend. :)

I'm not entirely sure what the issues are here, even after reading it over.

And it's LXQt, not LXQT.

@dnschneid
Copy link
Owner

I'm not entirely sure what the issues are here, even after reading it over.

that's because the issues are confusingly described here.

And it's LXQt, not LXQT.

this is why i just leave everything lowercase

@dnschneid
Copy link
Owner

@DennisLfromGA
Copy link
Collaborator

DennisLfromGA commented Nov 14, 2016

I ran into a conflict with a package that the lxqt target installs: 'connman'
with one that gtk-extra installs: 'network-manager'

gtk-extra:install_dummy network-manager network-manager-gnome

See this thread and comment for a few more details.

In the installer/prepare.sh script, the 'install' function can be used to avoid packages too, here's a snippet from the comments:

# install [--minimal] [--asdeps] --
# For the specified crouton-style package names (see distropkgs()), installs
# , while avoiding installing if they are not
# already installed.

There are a number of targets that avoid installing 'network-manager' to eliminate these conflicts, I've listed a few below -

chronos@localhost ~/Downloads/crouton.unbundled $ sudo grep network-manager targets/*
targets/kde:install --minimal kde-baseapps kde-runtime plasma-desktop pulseaudio \
targets/kde:        -- network-manager
targets/kde-desktop:install ubuntu=kubuntu-desktop,task-kde-desktop -- network-manager
targets/lxde:install lxde -- dictionaries-common chromium-browser network-manager wicd
targets/lxde-desktop:install ubuntu=lubuntu-desktop,task-lxde-desktop -- network-manager
targets/unity-desktop:install ubuntu-desktop -- network-manager xorg
targets/xfce-desktop:install ubuntu=xubuntu-desktop,task-xfce-desktop -- network-manager xorg

I don't know if I understand the 'install' function well enough to make any suggestions but your lxqt target could possibly drop the 'connman' package requirement by using something like:

install lxqt lxqt-common openbox -- connman

I'm not sure that's the correct syntax though.

I suppose I could have avoided this in my case by just not installing gtk-extra but others may want this and other desktops along with lxqt so I thought I'd meniton it.

-DennisL

@Serkan-devel
Copy link

Is this still being worked on?

@zxvv
Copy link
Contributor Author

zxvv commented Jan 26, 2019

I'm not able to work on this currently, and if others would like to take it up, I'm happy to support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants