Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on gRPC to generate random port #9102

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Rely on gRPC to generate random port #9102

merged 1 commit into from
Apr 27, 2023

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Apr 26, 2023

To avoid occasionally binding to a port still in use.

@rongou
Copy link
Contributor Author

rongou commented Apr 26, 2023

@trivialfis @hcho3

trivialfis
trivialfis reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to just query port 0 on unix?

@rongou
Copy link
Contributor Author

rongou commented Apr 26, 2023

No 0 just tells the server builder to pick a random unused port. The client needs the actual port number to connect.

@trivialfis trivialfis merged commit 511d499 into dmlc:master Apr 27, 2023
@rongou rongou deleted the fix-random-port branch September 25, 2023 16:41
@ShellLM ShellLM mentioned this pull request Aug 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongou @trivialfis