Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, It takes 70s to finish test_classifier_with_cross_validator
70.03s call python/test_spark/test_spark_local.py::XgboostLocalTest::test_classifier_with_cross_validator
With this PR, it only takes 17s to be finished
17.43s call python/test_spark/test_spark_local.py::XgboostLocalTest::test_classifier_with_cross_validator
I also tried enabling pytest with parallelly running by pytest-xdist and it worked well with pyspark tests, and the time can be reduced from
4m49.335s
to2m19.574s
.I don't know if we need to enable pytest-xdist for python tests?
BTW, I also found some tests may have overlaps, like
test_classifier_distributed_weight_eval
andtest_regressor_distributed_weight_eval
, seems we don't need to test all kinds of estimators @WeichenXu123, please correct me.