Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GPU Hist tests. #10677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleanup GPU Hist tests. #10677

wants to merge 2 commits into from
106 −185

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Aug 5, 2024 •
edited
Loading

  • Remove GPU Hist gradient sampling test. The same properties are tested in the gradient sampler test suite.
  • Move basic histogram tests into the histogram test suite.
  • Remove the header inclusion of the updater_gpu_hist.cu in tests.

Follow up of #10608

@trivialfis
Cleanup GPU Hist tests.
0aab3ac 
- Remove GPU Hist gradient sampling test. The same properties are tested in the gradient
  sampler test suite.
- Move basic histogram tests into the histogram test suite.
- Remove the header inclusion of the `updater_gpu_hist.cu` in tests.
@trivialfis
Copy link
Member Author

cc @rongou .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trivialfis @rongou