Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove global random engine. #10354

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[WIP] Remove global random engine. #10354

wants to merge 5 commits into from

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented May 31, 2024 •
edited
Loading

Move the random engine into the context.

todos:

  • Seed the rng based on the number of boosted rounds.
  • Test serialization with sampling.
  • Test with related issues.

Related:

@trivialfis
Copy link
Member Author

trivialfis commented Jun 5, 2024 •
edited
Loading

Note:

  • Creating a column sampler runs the random engine to get an initial seed.
  • The failing test gtest is caused by the difference in the serialized rng state instead of the output model.

@trivialfis trivialfis mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trivialfis