Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Mock IO in the Dub class too #2941

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Tests: Mock IO in the Dub class too #2941

wants to merge 8 commits into from

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jun 22, 2024

This will allow to write more tests for the Dub class. In particular I am interested in being able to write unittests around the config file, which require loadConfig to be callable. We still need to call thisExePath at the moment but that can be solved later as it has no visible side effect.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2024 •
edited
Loading

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 8

Total warnings: 0

Build statistics:

 statistics (-before,  after)
-executable size=5297464 bin/dub
 executable size=5301560 bin/dub
 rough build time=63s
Full build output 
DUB version 1.38.0, built on Jul  4 2024
LDC - the LLVM D compiler (1.39.0):
  based on DMD v2.109.1 and LLVM 18.1.6
  built with LDC - the LLVM D compiler (1.39.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.39.0/x64/ldc2-1.39.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.39.0-beta.1 commit.27.gaa1cf422: building configuration [application]
source/dub/internal/dyaml/composer.d(210,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/composer.d(232,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/composer.d(336,43): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(196,5): Deprecation: cannot access overlapped field `Event.explicitDocument` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(214,5): Deprecation: cannot access overlapped field `Event.explicitDocument` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(241,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(148,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
source/dub/internal/dyaml/event.d(148,5): Deprecation: cannot access overlapped field `Event.implicit` with unsafe bit patterns in `@safe` code
     Linking dub
STAT:statistics (-before,  after)
STAT:executable size=5301560 bin/dub
STAT:rough build time=63s

@Geod24 Geod24 force-pushed the mlang/FS branch 4 times, most recently from 04512c4 to 99b5776 Compare June 23, 2024 22:39
@Geod24 Geod24 mentioned this pull request Jun 24, 2024
Merged
@Geod24 Geod24 force-pushed the mlang/FS branch 2 times, most recently from b136a85 to 190d56a Compare June 25, 2024 08:10
@Geod24 Geod24 force-pushed the mlang/FS branch 3 times, most recently from 81b8167 to 8b54204 Compare June 25, 2024 16:38
@Geod24 Geod24 force-pushed the mlang/FS branch 5 times, most recently from 07e4824 to fe73ed3 Compare July 12, 2024 23:14
@Geod24 Geod24 force-pushed the mlang/FS branch 2 times, most recently from b25f9db to 44f1d91 Compare September 22, 2024 12:08
@Geod24
feat(fs): Implement chdir to change the working directory
a051dbf 
Currently our working directory is always the root,
which means that we didn't care about absolute vs relative path
until now.
@Geod24
fix(mockfs): Improve Windows support and add tests
8d47440 
On Windows, the root has a name, which is the drive,
unlike on POSIX where the root is an empty name.
This led to a flurry of problems because we assumed
a POSIX style, where the FS is a directed graph,
while on Windows it is multiple unconnected graphs
(the drives cannot be accessed via a relative path).
@Geod24
fix(tests): Give a non-root CWD to tests
1849d1b 
In the real world, it's unlikely Dub is ever started from the root path.
However, in our current unittest framework, that is always the case.
@Geod24
CI: Move Filesystem instance to Dub class
4f1ec76 
While we don't use it yet, it allows us to remove the field from out TestDub class
@Geod24
Instantiate PackageManager with Dub's Filesystem instance
c2991aa 
This way we can start making use of the Filesystem abstraction in the Dub class.
@Geod24
Remove most dependency to std.file and dub.internal.core.file from Dub
a9b4621 
By using the Filesystem instance we can start writing better tests,
in this case getting the ability to load configurations from tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geod24 @thewilsonator