Skip to content

Commit

Permalink
fix(npm): use correct flags and update version for npm (coder#5533)
Browse files Browse the repository at this point in the history
* fix: update npm-postinstall.sh script

Add --legacy-peer-deps to deal with weird npm issue with vscode
dependencies.

See: https://stackoverflow.com/a/66620869/3015595

* fix: use npm in release-standalone

* chore: update package.json

* chore: bump plugin engine for tests
  • Loading branch information
jsjoeio committed Sep 6, 2022
1 parent 6742e94 commit da03a64
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ci/build/build-standalone-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 28,7 @@ main() {
ln -s "./lib/node" "$RELEASE_PATH/node"

pushd "$RELEASE_PATH"
yarn --production --frozen-lockfile
npm install --unsafe-perm --omit=dev
popd
}

Expand Down
2 changes: 1 addition & 1 deletion ci/build/npm-postinstall.sh
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 140,7 @@ install_with_yarn_or_npm() {
echo "yarn.lock file present, running in development mode. use yarn to install code-server!"
exit 1
else
npm install --omit=dev
npm install --unsafe-perm --legacy-peer-deps --omit=dev
fi
;;
*)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 1,7 @@
{
"name": "code-server",
"license": "MIT",
"version": "4.6.1",
"version": "4.6.1-1",
"description": "Run VS Code on a remote server.",
"homepage": "https://github.com/coder/code-server",
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/node/test-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 3,7 @@
"name": "test-plugin",
"version": "1.0.0",
"engines": {
"code-server": "^4.0.1"
"code-server": "^4.6.1-1"
},
"main": "out/index.js",
"devDependencies": {
Expand Down

0 comments on commit da03a64

Please sign in to comment.