Use postcard to serialize cookie data #81
Conversation
postcard has a documented wire format and should serialize to smaller messages, so it seems like a more attractive option.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #81 /- ##
=======================================
Coverage 57.32% 57.32%
=======================================
Files 7 7
Lines 1378 1378
=======================================
Hits 790 790
Misses 588 588
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I don't have a strong opinion on serialization formats but some benchmarks show MessagePack (popular and similarly well-specced) to be smaller for fewer fields, but a bit slower. I only bring it up since the serialization format is a breaking change.
I see postcard does better in benchmarks for strings though. Overall postcard does seem better than bincode in almost every respect (maintenance, specification, size, speed), so should be fine.
|
I think https://github.com/djkoloski/rust_serialization_benchmark is the definitive benchmark right now. From that data, it looks like there's not a big difference on the size axis between MessagePack and postcard. I like that postcard is tightly scoped, works within the serde data model and appears to be well-documented -- I think it will serve us well. |
@cycraig want to review this?