Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in docs/howto/initial-data.txt. #18516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @jacobtylerwalls for this work! 🌟

Let me know what you think about my proposal, happy to merge either way.

@@ -85,15 85,15 @@ Tell Django where to look for fixture files
-------------------------------------------

By default, Django looks for fixtures in the ``fixtures`` directory inside each
app for, so the command ``loaddata sample`` will find the file
app, so the command ``loaddata sample`` will find the file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the original intent was to say "folder"? I think it may be clearer... How about:

Suggested change
app, so the command ``loaddata sample`` will find the file
app folder, so the command ``loaddata sample`` will find the file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the blame, I think "for" was in the original version: "looks ... inside each app for fixtures", so I don't think it was intending to say folder. Whether we should add it, I don't have a strong opinion, but I think it might be nicer to keep it shorter. (The ", so ..." is already too run-on for my taste.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants