Fixed #35702 -- Removed connection pooling note for mysql drivers. #18512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisham-Pak
changed the title
charettes
reviewed
Aug 23, 2024
docs/ref/databases.txt
Outdated
Comment on lines
482
to
484
| These drivers are thread-safe and provide connection pooling. | ||
| The MySQL Connector/Python driver is thread-safe and supports connection | ||
| pooling, whereas mysqlclient does not have built-in connection pooling | ||
| capabilities. |
There was a problem hiding this comment.
While MySQL Connector/Python supports connection pooling through mysql.connector.pooling source Django itself doesn't make use of it like we do with Postgres so I wonder if its even worth pointing out. Thoughts on that @sarahboyce and @apollo13 since you worked on fad334e.
There was a problem hiding this comment.
Do you think its worth mentioning mysqlclient, or should this note be removed altogether?
There was a problem hiding this comment.
Removed in fdae943.
|
Yeah, I feel like the current sentence doesn't provide much value so we might just able to get rid of it? I also doubt that even if a MySQL client supported transparent pooling that it would be useable on Django without changes (ie reset timezone on pool change etc).
…On Sat, Aug 24, 2024, at 00:27, Simon Charette wrote:
***@***.**** commented on this pull request.
In docs/ref/databases.txt
<#18512 (comment)>:
> -These drivers are thread-safe and provide connection pooling.
The MySQL Connector/Python driver is thread-safe and supports
connection
pooling, whereas mysqlclient does not have built-in connection pooling
capabilities.
While `MySQL Connector/Python` supports connection pooling through
`mysql.connector.pooling` source
<https://dev.mysql.com/doc/connector-python/en/connector-python-connection-pooling.html>
Django itself doesn't make use of it like we do with Postgres so I
wonder if its even worth pointing out. Thoughts on that @sarahboyce
<https://github.com/sarahboyce> and @apollo13
<https://github.com/apollo13> since you worked on fad334e
<fad334e>.
—
Reply to this email directly, view it on GitHub
<#18512 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT5C6CUF6PHG3HZ7BEEF3ZS6ZOXAVCNFSM6AAAAABNAJZSCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJYGE4DENZRGE>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hisham-Pak
force-pushed
the
ticket_35702
branch
from
c2c176f
to
fdae943
Compare
Hisham-Pak
changed the title
sarahboyce
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35702
Branch description
This branch makes changes to docs to clarify
mysqlclientdoes not have built-in connection pooling.Checklist
mainbranch.