Fixed #35690 -- Raise TypeError if QuerySet.in_bulk is called after QuerySet.values or QuerySet.values_list. #18496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-parton
commented
Aug 19, 2024
6 tasks
john-parton
force-pushed
the
bugfix/35690-in-bulk-after-values
branch
from
e7971a9
to
26785dc
Compare
|
Just pushed a change replacing |
john-parton
force-pushed
the
bugfix/35690-in-bulk-after-values
branch
from
26785dc
to
36f0838
Compare
|
Force-pushed changes to test to make them more complete. |
sarahboyce
force-pushed
the
bugfix/35690-in-bulk-after-values
branch
from
36f0838
to
6fc9da5
Compare
…r values_list() queryset.
sarahboyce
force-pushed
the
bugfix/35690-in-bulk-after-values
branch
from
6fc9da5
to
59f42e9
Compare
sarahboyce
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
35690
Branch description
When calling QuerySet.values() followed by QuerySet.in_bulk(), an
AttributeErroris raised, which doesn't directly give the user feedback on how to resolve the error or what the user even did wrong. This adds an additional check and raises aTypeErrorwith the appropriate message.I can try and define the behavior, but I wanted to submit the simpler pull request for review before working on a more complicated fix.
Let me know if docs are required. A simple short note on the
in_bulkmethod might be sufficient.Checklist
mainbranch.