Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #18296 -- Create custom target directory if missing in startproject and startapp #18387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Jul 18, 2024

Trac ticket number

ticket-18296

Branch description

Given the following project structure, where apps is a directory:

.
├── apps
├── manage.py
└── myproject
    ├── __init__.py
    ├── asgi.py
    ├── settings.py
    ├── urls.py
    └── wsgi.py

If I run:

$ django-admin startapp app1 apps/app1
CommandError: Destination directory '/Users/bruno/.../myproj/apps/app1' does not exist, please create it first.

This can cause some friction with beginners, and it feels like it would be something that Django could create out of the box.

The code is shared with startproject, so this PR is doing it for both, as I couldn't find a reason why not.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@browniebroke browniebroke force-pushed the ticket-18296 branch 2 times, most recently from 9157dd0 to 07c8b55 Compare July 18, 2024 13:24
@browniebroke browniebroke marked this pull request as ready for review July 18, 2024 13:37
@browniebroke
Copy link
Contributor Author

browniebroke commented Jul 18, 2024

I think the failing jobs are failing to start due to some infra issues: java.io.IOException: No space left on device. Going to assume they're unrelated, but let me know if I miss anything

EDIT: seems resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant